After seeing feedback on some other pull requests, I noticed that single quotes were preferred. I've accordingly, and preemptively, converted our single quotes to double quotes. I took the opportunity to double check the style guide and make sure everythiyng else was tidied up as well.
Fixes#8378 by rewriting the CNBC video extractor.
- Removes `CNBCIE`, which is an extractor for a CNBC video platform that no longer exists.
- Updates CNBCVideoIE
- Adds tests
- Supports author, channel, formats, ID (of course), upload date, URL (of course), title (of course), description, duration, timestamp, and thumbnails.
Squashed commit of the following:
commit c4c6a3ecf7cb287ffdb9a20e571b9036e6519d77
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 20:12:51 2023 -0500
Final cleanups
commit 98837e5fcd0735165be2de47770143a480ee7ffc
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 20:06:01 2023 -0500
Rebase 'Further cleanups + better extraction'
Cool.
commit 210a0e5fedc5ecd734a594cb5bed9df9370e0e3b
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 19:48:58 2023 -0500
new tests
commit 91fcdfbcde07016c71b7b2c697391cee5d883cd7
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 19:41:45 2023 -0500
added a test
commit 28a0100a2077febf03b3b53b7c0d291603cb8f18
Author: ruiminggu <ruimingg@andrew.cmu.edu>
Date: Sat Dec 9 19:11:34 2023 -0500
fixed test
commit 37c4b72c13cd2a76810c03ec5ee6039f1dc972ec
Author: ruiminggu <ruimingg@andrew.cmu.edu>
Date: Sat Dec 9 19:11:17 2023 -0500
fixed test
commit 6f42a60a4345f67f6fb209437e112e86091e317b
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 18:47:17 2023 -0500
Remove CNBCIE
Seems to not exist anymore.
commit d9dd7421e869d79cc5dbb0941c5fb1500b99912b
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 18:44:11 2023 -0500
Code cleanups
commit 72e9d82b6ee4fcfc5c83e7c478835a18534fd387
Merge: b27267943 b5260a1ba
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 18:36:30 2023 -0500
Merge branch 'rachel-cnbc' into cnbc
commit b27267943e460f036556483908327a298aa4238d
Merge: 1823eb938 188191ad9
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 18:35:33 2023 -0500
Merge branch 'noor-cnbc' into cnbc
commit 188191ad953f23d8a176494f1a5677cb67057791
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 18:34:11 2023 -0500
Simplify noor-code
commit 7c43a9d44e0faf2ac6c69994044d08b83be54c58
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Sat Dec 9 17:37:00 2023 -0500
Mostly fix tests
Nice.
commit db204a54fdd281dc112480ed9b1746418734ce62
Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu>
Date: Sat Dec 9 17:18:57 2023 -0500
test case for CNBC video
commit b5260a1bace19436fdc1f0221459100e638c11bf
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 17:17:04 2023 -0500
format upload_date
commit 1823eb9385bd4adc3d99d6b683c150cc6840250b
Author: ruiminggu <ruimingg@andrew.cmu.edu>
Date: Sat Dec 9 15:55:04 2023 -0500
modify for properly capitalize the channel
commit c164f09081bd08549314daec0d0eadc15fd0552a
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 15:38:40 2023 -0500
add the case where author is NA
commit 3bee446904b262a68463da0c1af09db3550b532c
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 15:26:03 2023 -0500
upload_date, video_status, author
commit 668503b51397c8bdf0e138c736074d86489e2d15
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 15:25:08 2023 -0500
original
commit fb8f1731931bd379d5565c39b1aef2391bf14356
Author: zhijinwuu <zhijinw@andrew.cmu.edu>
Date: Sat Dec 9 15:09:44 2023 -0500
upload_date, video_status, and author
commit b57090bfc21c79864f8875aa0cfb3c1472e15323
Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu>
Date: Fri Dec 8 16:24:36 2023 -0500
metadata using builtin functions
commit a3b0068111fa78524e950e2a827a8e07c54cc918
Author: ruiminggu <ruimingg@andrew.cmu.edu>
Date: Fri Dec 8 14:59:57 2023 -0500
channel and duration
commit 09ccfd73dd4025c8031c564e83d3cd8a23dd8ec0
Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu>
Date: Thu Dec 7 17:16:17 2023 -0500
Added metadata for thumbnail, timestamp, and description
commit fcb554e870e21772770fbdc2f22ac1ec3e397b37
Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu>
Date: Thu Dec 7 14:51:10 2023 -0500
thumbnail metadata
commit 2101192145479f57222e4d1598880e74ee43fef0
Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm>
Date: Thu Dec 7 12:45:36 2023 -0500
Basic video extraction supported for CNBC.
Does the absolute barest minimum.
