Commit Graph

366 Commits

Author SHA1 Message Date
Leonardo Lang
dc10fd8c44 Fix out-of-bounds access on TextView
Frequent updates to `TextContent` while the screen is being refreshed can
trigger an out-of-bounds access: an update with a smaller string being
performed between calls to `compute_rows()` and `draw()` on TextView will
cause an out-of-bounds access when slicing the string at `Segment::resolve`.

This change fixes the issue by caching the content value when performing
size calculations and using this cached content when drawing the view.

Some additional changes were also made to reuse `TextContent` invalidation
code on `TextView` and wrap content data with `RefCell<Arc<..>>` to enable
sharing the inner string between `content_value` and `content_cache`.
2019-08-01 20:29:50 -04:00
Alexandre Bury
b7d71e8381 Rustfmt
Moves to "Tall" fn_args_layout
2019-07-30 16:08:40 -07:00
Timon
bddb1a9dde Crossterm Performance Update (#361) 2019-07-30 09:48:50 -07:00
Alexandre Bury
ef60cd0a76 Add ListView::remove_child 2019-07-26 15:36:19 -07:00
Danil Berestov
976cb99bdb Remove extra check (#357) 2019-06-27 16:19:07 -07:00
Alexandre Bury
ad23dfe59b Add ScrollView::{inner_size, is_at_{bottom, top, left, right}} 2019-06-23 21:53:11 -04:00
Alexandre Bury
0c8a7b2708 Rename repo name to use lowercase 2019-06-19 14:39:11 -04:00
Alexandre Bury
269f2ab521 Add dyn to trait objects 2019-06-18 11:44:47 -07:00
Mark LeMoine
39e14d8c93 Add getters for current and max value in SliderView (#353) 2019-06-07 09:47:48 -07:00
Alexandre Bury
23d65aa9dc Update examples and tutorials to Rust 2018 2019-05-20 15:53:22 -07:00
Alexandre Bury
51c6450688 Rustfmt 2019-04-11 17:08:55 -07:00
Chris Vest
88037717e6 Add a sort method to SelectView, to easily sort all contained items lexicographically by their label. (#329)
* Add a sort method to SelectView, to easily sort all contained items lexicographically by their label.

* Add more sort methods to SelectView, bringing the API up to parity with Vec (except SelectView does not expose _unstable_ sorting).

* Rename SelectView::sort to sort_by_label to make it clear that it does not sort by the ordering of the items.

* The Ord implementation for select_view::Item is not necessary.

* Implement a SelectView::sort method for when the item values are orderable.
2019-03-30 10:22:08 -07:00
Alexandre Bury
038294339d Fix clippy warning 2019-03-20 17:05:18 -07:00
Alexandre Bury
4b5a7867e3 Refactor scroll::Core mechanism.
Moved most View-trait-performing-functions outside of `scroll::Core`
into `scroll::raw`.
Added a `Scroller` trait and convenience methods like `scroll::layout` to
weave the borrows appropriately.
2019-03-12 14:31:56 -07:00
Alexandre Bury
12ad66badd Migrate MenuPopup to new scrollbase 2019-03-08 13:57:05 -08:00
Alexandre Bury
6f28569dae Move logic from ScrollView to ScrollCore 2019-03-04 20:08:40 -08:00
mukund
bfbdf5c26b
Fix a typo in text-view.rs (content -> view) 2019-03-04 12:10:35 -08:00
Alexandre Bury
242a3c68a7 Fix clippy warnings 2019-03-04 10:31:36 -08:00
Alexandre Bury
bcf5840c52 Add LinearLayout::{insert_child, swap_children, set_weight} 2019-03-03 10:55:43 -08:00
Chris Vest
7564a5d1db Reduce the title drawing cut-off point by 2 characters.
Panels and dialogs have borders with corners.
Previously, the title would draw over the border corner, including its own end-points.
Now the cut-off point is such that we do not draw the title if the right-hand end point and the border-corner do not also fit.
2019-03-03 10:37:53 +01:00
Alexandre Bury
40adcffbf5 Revert "use ... as _" to stay compatible with rust 1.31 2019-03-01 09:29:56 -08:00
Alexandre Bury
06b02e4665 Remove "extern crate" and rustfmt 2019-02-28 16:04:14 -08:00
Alexandre Bury
e096dc9740 Run cargo fix --edition-idioms 2019-02-28 15:55:10 -08:00
Alexandre Bury
e51be07e5d Update to Rust 2018
Run `cargo fix --edition` and update Cargo.toml
2019-02-28 15:54:12 -08:00
Alexandre Bury
d7e57fd280 Rename toggle_debug_view -> toggle_debug_console 2019-02-22 15:02:34 -08:00
Alexandre Bury
3a7e10cffe Update debug view 2019-02-22 13:55:07 -08:00
Alexandre Bury
8b3f5a8de7 Add CursiveLogger and DebugView 2019-02-22 12:38:16 -08:00
Alexandre Bury
027038db6f Add StackView::remove_layer 2019-02-12 17:24:34 -08:00
Alexandre Bury
ec8f7c93e8 Wrap each layer in a CircularFocus 2019-01-24 11:57:30 -08:00
Alexandre Bury
3e1eefd2db Add CircularFocus view
Can be used to have focus wrap around when pressing Tab or Arrow keys.
2019-01-24 11:47:22 -08:00
Daniel Akhterov
1862b94c56 Hide Scrollbars 2018-12-30 14:49:23 -08:00
Alexandre Bury
2ab81ae6c9 Add HideableView::is_visible 2018-12-20 13:39:55 -08:00
Alexandre Bury
a6d9b46bf3
Merge pull request #299 from agavrilov/radiogroup_callback
Add on_change callback to `RadioGroup`
2018-11-30 15:46:23 -08:00
Alexander Gavrilov
fcfca86a36 Add chainable variant of on_change 2018-11-30 15:44:56 -08:00
Alexander Gavrilov
8ea55a69a0 Add on_change callback 2018-11-30 14:34:17 -08:00
Alexandre Bury
6b278495d5 Use StyledString in SelectView 2018-11-30 13:19:08 -08:00
Alexandre Bury
7a58970163 Add PaddedView 2018-11-18 20:05:31 -08:00
Alexandre Bury
8e016a7f0a Update doc and changelog 2018-11-09 14:38:04 -08:00
Alexandre Bury
edeb7a8c13 Add EnableableView 2018-11-09 14:19:37 -08:00
Alexandre Bury
193f098ee0 Add Printer::enabled 2018-11-09 14:08:43 -08:00
Alexandre Bury
b60c69ca63 Fix example and add doc tests 2018-11-09 10:54:57 -08:00
Alexandre Bury
d9d34b4350 Add EventTrigger, refactor OnEventView 2018-11-09 10:40:06 -08:00
Alexandre Bury
9b3b16f64d Fix important_size for SelectView and ListView 2018-10-18 13:36:17 -07:00
Jacob Budin
38fdcc7bf8 Simplify Panel::wrap_needs_relayout 2018-10-02 14:20:14 -04:00
Jacob Budin
8d3be52927 Add title to views::Panel 2018-10-02 12:02:10 -04:00
Alexandre Bury
3d81ad92ec SelectView: make autojump opt-in 2018-09-27 16:01:37 -07:00
Alexandre Bury
333392e034 Add immut! macros 2018-09-24 14:28:23 -07:00
Alexandre Bury
810dc6a591 Fix desperate LinearLayout 2018-09-12 16:13:41 -07:00
Alexandre Bury
760cf11d92 Invalidate cache on mutable child access 2018-08-26 12:25:22 -07:00
Ben-Alderson
fe93b945fd Fix crash when removing a child from LinearLayout when final child has focus 2018-08-26 14:58:23 -04:00