arnekeller/cursive
1
0
Fork 0
mirror of https://github.com/FliegendeWurst/cursive.git synced 2024-11-23 17:35:00 +00:00
Code Issues Projects Releases Wiki Activity

fix: protect scroll operations when non-scrollable

Browse Source 
Fixes #109
This commit is contained in:
Alexandre Bury 2017-02-26 14:53:50 -08:00
parent e91021a633
commit 34c7462877
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/view/scroll.rs
View File

@ -119,22 +119,28 @@ impl ScrollBase {
/// Scroll to the bottom of the view. /// Scroll to the bottom of the view.
pub fn scroll_bottom(&mut self) { pub fn scroll_bottom(&mut self) {
self.start_line = self.content_height - self.view_height; if self.scrollable() {
self.start_line = self.content_height - self.view_height;
}
} }
/// Scroll down by the given number of line. /// Scroll down by the given number of line.
/// ///
/// Never further than the bottom of the view. /// Never further than the bottom of the view.
pub fn scroll_down(&mut self, n: usize) { pub fn scroll_down(&mut self, n: usize) {
self.start_line = min(self.start_line + n, if self.scrollable() {
self.content_height - self.view_height); self.start_line = min(self.start_line + n,
self.content_height - self.view_height);
}
} }
/// Scroll up by the given number of lines. /// Scroll up by the given number of lines.
/// ///
/// Never above the top of the view. /// Never above the top of the view.
pub fn scroll_up(&mut self, n: usize) { pub fn scroll_up(&mut self, n: usize) {
self.start_line -= min(self.start_line, n); if self.scrollable() {
self.start_line -= min(self.start_line, n);
}
} }
/// Draws the scroll bar and the content using the given drawer. /// Draws the scroll bar and the content using the given drawer.