arnekeller/cursive
1
0
Fork 0
mirror of https://github.com/FliegendeWurst/cursive.git synced 2024-11-23 17:35:00 +00:00
Code Issues Projects Releases Wiki Activity

Fix clippy warning in tutorial 3 (#374)

Browse Source 
- Writing `&String` instead of `&str` involves a new object where a
  slice will do
  See https://rust-lang.github.io/rust-clippy/master/#ptr_arg
This commit is contained in:
Miguel Madrid Mencía 2019-09-06 19:23:44 +02:00 committed by Alexandre Bury
parent 3ff9c3ce0d
commit 1fcb9db79c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/tutorial_3.md
View File

@ -71,7 +71,7 @@ fn delete_name(s: &mut Cursive) {
} }
} }
fn on_submit(s: &mut Cursive, name: &String) { fn on_submit(s: &mut Cursive, name: &str) {
s.pop_layer(); s.pop_layer();
s.add_layer(Dialog::text(format!("Name: {}\nAwesome: yes", name)) s.add_layer(Dialog::text(format!("Name: {}\nAwesome: yes", name))
.title(format!("{}'s info", name)) .title(format!("{}'s info", name))
@ -117,14 +117,14 @@ let select = SelectView::<String>::new()
We'll also want to add a callback when the user chooses a name. The We'll also want to add a callback when the user chooses a name. The
[`SelectView::on_submit`] method takes a callback with a second argument: [`SelectView::on_submit`] method takes a callback with a second argument:
the selected item. Since we're using `String`, our callback will have to be the selected item. Since we're using `String`, our callback will have to be
`Fn(&mut Cursive, &String)`: `Fn(&mut Cursive, &str)`:
```rust,ignore ```rust,ignore
let select = SelectView::<String>::new() let select = SelectView::<String>::new()
.on_submit(on_submit) .on_submit(on_submit)
.fixed_size((10, 5)); .fixed_size((10, 5));
fn on_submit(s: &mut Cursive, name: &String) { fn on_submit(s: &mut Cursive, name: &str) {
s.pop_layer(); s.pop_layer();
s.add_layer(Dialog::text(format!("Name: {}\nAwesome: yes", name)) s.add_layer(Dialog::text(format!("Name: {}\nAwesome: yes", name))
.title(format!("{}'s info", name)) .title(format!("{}'s info", name))