mirror of
https://github.com/FliegendeWurst/cursive.git
synced 2024-11-08 18:30:40 +00:00
Fix clippy warning in tutorial 3 (#374)
- Writing `&String` instead of `&str` involves a new object where a slice will do See https://rust-lang.github.io/rust-clippy/master/#ptr_arg
This commit is contained in:
parent
3ff9c3ce0d
commit
1fcb9db79c
@ -71,7 +71,7 @@ fn delete_name(s: &mut Cursive) {
|
||||
}
|
||||
}
|
||||
|
||||
fn on_submit(s: &mut Cursive, name: &String) {
|
||||
fn on_submit(s: &mut Cursive, name: &str) {
|
||||
s.pop_layer();
|
||||
s.add_layer(Dialog::text(format!("Name: {}\nAwesome: yes", name))
|
||||
.title(format!("{}'s info", name))
|
||||
@ -117,14 +117,14 @@ let select = SelectView::<String>::new()
|
||||
We'll also want to add a callback when the user chooses a name. The
|
||||
[`SelectView::on_submit`] method takes a callback with a second argument:
|
||||
the selected item. Since we're using `String`, our callback will have to be
|
||||
`Fn(&mut Cursive, &String)`:
|
||||
`Fn(&mut Cursive, &str)`:
|
||||
|
||||
```rust,ignore
|
||||
let select = SelectView::<String>::new()
|
||||
.on_submit(on_submit)
|
||||
.fixed_size((10, 5));
|
||||
|
||||
fn on_submit(s: &mut Cursive, name: &String) {
|
||||
fn on_submit(s: &mut Cursive, name: &str) {
|
||||
s.pop_layer();
|
||||
s.add_layer(Dialog::text(format!("Name: {}\nAwesome: yes", name))
|
||||
.title(format!("{}'s info", name))
|
||||
|
Loading…
Reference in New Issue
Block a user