Riteo
62e274f515
Move regular subtitles options to their loop
2024-08-14 02:10:14 +02:00
Riteo
e202aae5d6
Remove redundant copy_unknown
2024-08-14 02:03:09 +02:00
Riteo
3b8050da5b
Merge remote-tracking branch 'origin/master' into json-subtitles
2024-08-14 02:02:56 +02:00
Riteo
38a9f70044
Use a map for JSON sub handling instead of two lists
2024-08-14 01:16:15 +02:00
Riteo
550b3a046a
Use the -copy_unknown flag in the stream copy otions
...
Also split the yield expression as the comment above was a bit
misleading (it was only related to the `-dn` flag).
2024-08-13 22:30:08 +02:00
bashonly
d502f4c6d9
[pp/embedthumbnail] Fix embedding with mutagen ( #10337 )
...
Fixes regression in f2a4ea1794Closes #10335
Authored by: bashonly
2024-07-02 21:24:17 +00:00
bashonly
6aaf96a3d6
[cleanup] Misc ( #10075 )
...
Closes #10303
Authored by: bashonly, seproDev, jucor, c-basalt
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: Julien Cornebise <julien@cornebise.com>
Co-authored-by: c-basalt <117849907+c-basalt@users.noreply.github.com>
2024-07-01 22:51:27 +00:00
Simon Sawicki
f2a4ea1794
[pp/embedthumbnail] Fix postprocessor ( #10248 )
...
* [compat] Improve `imghdr.what` detection
* [pp/embedthumbnail] Improve imghdr fail message
* [pp/embedthumbnail] Fix AtomicParsley error handling
Authored by: Grub4K
2024-06-27 16:12:19 +02:00
Riteo
ba3a7232f0
[pp/FFmpegEmbedSubtitle] Embed JSON subtitles as Matroska attachments
...
Since we can't embed them as regular subtitles (due to them not having
any consistent structure), we embed them as file attachments, if
exporting as Matroska.
This allows us to have single-file downloads with everything embedded
for e.g. archival purposes.
2024-06-14 16:56:54 +02:00
Riteo
339828d777
[pp/FFmpegMetadata] Use metadata stream specifier for info.json
...
The old stream index specifiers would indiscriminately select any JSON
attachment, which made stuff like embedding live chat json data risky if
not impossible.
Also adds `-copy_unknown` as JSON data is "unknown" according to FFmpeg
(since it has no codec id) and thus would otherwise be rejected by
default.
2024-06-14 16:56:52 +02:00
sepro
add96eb9f8
[cleanup] Add more ruff rules ( #10149 )
...
Authored by: seproDev
Reviewed-by: bashonly <88596187+bashonly@users.noreply.github.com>
Reviewed-by: Simon Sawicki <contact@grub4k.xyz>
2024-06-12 01:09:58 +02:00
pukkandan
47ab66db0f
[docs] Misc Cleanup ( #8977 )
...
Closes #8355 , #8944
Authored by: bashonly, Grub4k, Arthurszzz, seproDev, pukkandan
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: bashonly <bashonly@protonmail.com>
Co-authored-by: Arthurszzz <minecraftgamerarthur@gmail.com>
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
2024-03-11 00:48:47 +05:30
Lev
104a7b5a46
[ie] Migrate commonly plural fields to lists ( #8917 )
...
Authored by: llistochek, pukkandan
Related: #3944
2024-02-20 12:49:24 +05:30
bashonly
deeb13eae8
[pp/FFmpegMetadata] Embed stream metadata in single format downloads ( #8647 )
...
Closes #8568
Authored by: bashonly
2023-11-26 02:40:09 +00:00
Simon Sawicki
de015e9307
[core] Prevent RCE when using --exec with %q (CVE-2023-40581)
...
The shell escape function is now using `""` instead of `\"`. `utils.Popen` has been patched to properly quote commands.
Prior to this fix using `--exec` together with `%q` when on Windows could cause remote code to execute. See https://github.com/yt-dlp/yt-dlp/security/advisories/GHSA-42h4-v29r-42qg for reference.
Authored by: Grub4K
2023-09-24 02:29:01 +02:00
coletdjnz
3d2623a898
[compat, networking] Deprecate old functions ( #2861 )
...
Authored by: coletdjnz, pukkandan
2023-07-15 16:18:35 +05:30
Neurognostic
8a4cd12c8f
[pp/EmbedThumbnail] Support m4v ( #7583 )
...
Authored by: Neurognostic
2023-07-14 02:09:21 +05:30
pukkandan
13ff780953
[postprocessor] Print newline for --progress-template
...
Closes #7193
2023-06-17 01:43:09 +05:30
bashonly
3f7e2bd80e
[FFmpegFixupM3u8PP] Check audio codec before fixup ( #6778 )
...
Closes #6673
Authored by: bashonly
2023-04-13 19:21:09 +00:00
Lesmiscore
0f0875ed55
[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix error on attaching thumbnails and info json for mkv/mka ( #6647 )
...
Authored by: Lesmiscore
Current yt-dlp code never hit this bug, but would hit once filename sanitization gets better
2023-03-28 01:17:42 +09:00
bashonly
01ddec7e66
[postprocessor] Fix chapters if duration is not extracted ( #6037 )
...
Authored by: bashonly
2023-03-08 13:10:19 +00:00
pukkandan
a538772969
[cleanup] Misc
...
Closes #5897
2023-02-17 17:52:22 +05:30
Chris Caruso
f737fb16d8
[ExtractAudio] Handle outtmpl without ext ( #6005 )
...
Authored by: carusocr
Closes #5968
2023-02-17 13:36:15 +05:30
pukkandan
d80ca5deaa
[utils] mimetype2ext: weba is not standard
...
Fix bug in fbb73833062647c933b8Closes #5935
2023-01-03 11:25:01 +05:30
pukkandan
08e29b9f1f
[cleanup] Misc
...
Closes #5576 , closes #5887
2023-01-02 19:40:15 +05:30
Matthew
8e40b9d1ec
Improve plugin architecture ( #5553 )
...
to make plugins easier to develop and use:
* Plugins are now loaded as namespace packages.
* Plugins can be loaded in any distribution of yt-dlp (binary, pip, source, etc.).
* Plugin packages can be installed and managed via pip, or dropped into any of the documented locations.
* Users do not need to edit any code files to install plugins.
* Backwards-compatible with previous plugin architecture.
As a side-effect, yt-dlp will now search in a few more locations for config files.
Closes https://github.com/yt-dlp/yt-dlp/issues/1389
Authored by: flashdagger, coletdjnz, pukkandan, Grub4K
Co-authored-by: Marcel <flashdagger@googlemail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
2023-01-01 04:29:22 +00:00
pukkandan
69f5fe45b9
[FFmpegVideoConvertor] Add gif to --recode-video
2022-12-23 01:44:20 +05:30
Robert Geislinger
7aaf4cd2a8
[cleanup] Misc
...
Closes #5471 , Closes #5312
Authored by: pukkandan, Alienmaster
2022-11-11 15:48:29 +05:30
pukkandan
8522226d2f
[ThumbnailsConvertor] Fix filename escaping
...
Closes #4604
Authored by: pukkandan, dirkf
2022-11-11 15:28:19 +05:30
ClosedPort22
fbb0ee7747
[compat] Fix shutils.move in restricted ACL mode on BSD ( #5309 )
...
Authored by: ClosedPort22, pukkandan
2022-11-07 20:54:30 +05:30
pukkandan
d5d1df8afd
[cleanup Misc
...
Closes #5162
2022-10-18 23:52:44 +05:30
pukkandan
cd5df121f3
[SponsorBlock] Relax duration check for large segments
2022-10-18 23:36:59 +05:30
pukkandan
a7ddbc0475
[ModifyChapters] Handle the entire video being marked for removal
...
Closes #5238
2022-10-18 23:08:24 +05:30
pukkandan
8fab23301c
[SponsorBlock] Obey --retry-sleep extractor
2022-10-18 23:08:24 +05:30
pukkandan
1338ae3ba3
[SponsorBlock] Add type field
2022-10-18 23:08:23 +05:30
Ajay Ramachandran
63c547d71c
[SponsorBlock] Support chapter category ( #5260 )
...
Authored by: ajayyy, pukkandan
2022-10-18 22:21:57 +05:30
Noah
e02e6d86db
[embedthumbnail] Fix thumbnail name in mp3 ( #5163 )
...
Authored by: How-Bout-No
2022-10-07 17:34:27 +05:30
pukkandan
da4db748fa
[utils] Add deprecation_warning
...
See https://github.com/yt-dlp/yt-dlp/pull/2173#issuecomment-1097021515
2022-08-30 21:03:07 +05:30
pukkandan
0e0ce898f6
[ThumbnailsConvertor] Fix conversion after fixup_webp
...
Closes #4565
2022-08-14 20:34:55 +05:30
pukkandan
8420a4d063
[ffmpeg] Smarter detection of ffprobe filename
2022-08-11 07:23:45 +05:30
pukkandan
b5e9a641f5
[postprocessor/embedthumbnail] Detect libatomicparsley.so
2022-08-11 07:23:36 +05:30
pukkandan
c220d9efc8
[ffmpeg] Disable avconv unless --prefer-avconv
2022-08-09 05:15:38 +05:30
pukkandan
be5c1ae862
Standardize retry mechanism ( #1649 )
...
* [utils] Create `RetryManager`
* Migrate all retries to use the manager
* [extractor] Add wrapper methods for convenience
* Standardize console messages for retries
* Add `--retry-sleep` for extractors
2022-08-02 01:43:18 +05:30
pukkandan
5f2a7f7c4a
[FFmpegThumbnailsConvertor] Fix conversion from GIF
...
Closes #2988
2022-08-01 07:36:08 +05:30
pukkandan
4f04be6add
Validate --merge-output-format
...
Closes #4489
2022-07-31 02:20:14 +05:30
pukkandan
8dc5930511
[utils, cleanup] Consolidate known media extensions
2022-07-31 02:20:13 +05:30
pukkandan
6a7d3a0a09
[ffmpeg] Set ffmpeg_location in a contextvar
...
Fixes #2191 for the CLI, but not when used through the API
2022-07-31 02:20:12 +05:30
pukkandan
4f547d6d2c
[metadataparser] Don't set None when the field didn't match
...
Fixes: https://github.com/ytdl-org/youtube-dl/issues/31118#issuecomment-1198254512
2022-07-31 02:20:10 +05:30
pukkandan
3bec830a59
Reject entire playlists faster with --match-filter
...
Rejected based on `playlist_id` etc can be checked before any entries are extracted
Related: #4383
2022-07-26 09:33:12 +05:30
pukkandan
4019bf0525
[ModifyChapters] Modify duration in infodict
2022-07-11 01:10:38 +05:30
