[update] Set executable bit-mask

Closes #4621
This commit is contained in:
pukkandan 2022-08-14 19:03:58 +05:30
parent 8f84770acd
commit a6125983ab
No known key found for this signature in database
GPG Key ID: 7EEE9E1E817D0A39

View File

@ -9,7 +9,7 @@ import sys
from zipimport import zipimporter
from .compat import functools # isort: split
from .compat import compat_realpath
from .compat import compat_realpath, compat_shlex_quote
from .utils import (
Popen,
cached_method,
@ -229,24 +229,32 @@ class Updater:
except OSError:
return self._report_permission_error(new_filename)
try:
if old_filename:
if old_filename:
try:
os.rename(self.filename, old_filename)
except OSError:
return self._report_error('Unable to move current version')
try:
if old_filename:
os.rename(new_filename, self.filename)
except OSError:
self._report_error('Unable to overwrite current version')
return os.rename(old_filename, self.filename)
except OSError:
return self._report_error('Unable to move current version')
if detect_variant() not in ('win32_exe', 'py2exe'):
if old_filename:
os.remove(old_filename)
else:
try:
os.rename(new_filename, self.filename)
except OSError:
self._report_error('Unable to overwrite current version')
return os.rename(old_filename, self.filename)
if detect_variant() in ('win32_exe', 'py2exe'):
atexit.register(Popen, f'ping 127.0.0.1 -n 5 -w 1000 & del /F "{old_filename}"',
shell=True, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
elif old_filename:
try:
os.remove(old_filename)
except OSError:
self._report_error('Unable to remove the old version')
try:
os.chmod(self.filename, 0o777)
except OSError:
return self._report_error(
f'Unable to set permissions. Run: sudo chmod a+rx {compat_shlex_quote(self.filename)}')
self.ydl.to_screen(f'Updated yt-dlp to version {self.new_version}')
return True